STORM-1315: Ability to do simple math in numeric edit fields


Submitter:	Kadah Coba	Reviewers
Branch:		Groups:	viewer
Bugs:	STORM-1315	People:
Change Number:	None	Repository:	viewer-development

Description:

This is a direct adaptation of Aimee Trescothick's contributed patch from STORM-1315 for v-d. Adjustments were made where needed to make it work with the newer boost and llui code. Some changes were made to the variable names it uses on build; ie "PX" for x position instead of just "X".

Patch allows for imputing simple math equations in to the spinner controls. On the build floater a series of variable names are available for using the objects current values in equations, like "sx+3" will take the current X scale and add 3.

Repo: https://bitbucket.org/Kadah_Coba/storm-1315
Changeset: https://bitbucket.org/Kadah_Coba/storm-1315/changeset/d33ca6edf370

Testing Done:

Built and ran. Some testing done with simple equations on the build tools floater to edit an object, no issues were observed.

Expand All

Diff
- added Diff r2

Description:

Lets see if this diff wants to work.

Diff
- added Diff r3

Diff
- added Diff r4

Description:

Support for floor, ceil, modulo.
Fixed ABS.
Added more constants, SQRT_TWO_PI and SQRT3.

Diff
- added Diff r5

Description:

I have no idea why review board keeps breaking my diffs. Trying again.

Diff
- added Diff r6

Description:

Added the missing clears for the texture variables on no selection

Looks good code-wise.

indra/llmath/llcalc.cpp (Diff revision 6)

Why allocate dynamically?

Kadah Coba July 4, 2011, 1:05 p.m. (July 4, 2011, 1:05 p.m.)

I'm not sure, there's a lot of c++ voodoo going on in the original patch.

Vadim ProductEngine July 4, 2011, 1:54 p.m. (July 4, 2011, 1:54 p.m.)

I think dynamic allocation is redundant here, i.e. I'd convert the members to non-pointers and pass their addresses to the parser.

indra/llui/llspinctrl.cpp (Diff revision 6)

I'd add a note that we don't prevalidate because of the calculator.

Vadim ProductEngine July 4, 2011, 1:01 p.m. (July 4, 2011, 1:01 p.m.)
```
Oops. Ignore this comment.
```

indra/llui/llspinctrl.cpp (Diff revision 6)

dead code

Kadah Coba July 4, 2011, 1:06 p.m. (July 4, 2011, 1:06 p.m.)
```
Remove?
```

Vadim ProductEngine July 4, 2011, 1:52 p.m. (July 4, 2011, 1:52 p.m.)

Yes, our coding standard explicitly requires not to leave dead code.

Diff
- added Diff r7

Thanks.

You have a pending review.

Other reviews

Your comment

Review Board 1.6.11

This change has been marked as submitted.