All submissions to this site are governed by the Second Life Viewer Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.

Review Board 1.6.11

Welcome to the Second Life Viewer Code Review tool.
See the documentation on our wiki for how to use this site.

OPEN-99: use -march=pentium3 and -march=pentium4 only for 32 bit builds

Review Request #351 - Created June 20, 2011 and submitted

Boroondas Gupte Reviewers
viewer
CTS-315, OPEN-79, OPEN-99 nyx.linden
None viewer-development
These flags prevent building for 64-bit (both standalone or non-standalone), so only use them for 32-bit builds.
Tried a non-standalone 64-bit build (without using 64-bit prebuilts, though):
	Fails with
		[ 11%] Building CXX object llcommon/CMakeFiles/llcommon.dir/u64.o
		Linking CXX shared library libllcommon.so
		/usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld: skipping incompatible ${SRC_DIR}/build-linux-i686/packages/lib/release/libbreakpad_client.so when searching for -lbreakpad_client
		/usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld: skipping incompatible ${SRC_DIR}/build-linux-i686/packages/lib/release/libaprutil-1.so when searching for -laprutil-1
		/usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld: skipping incompatible ${SRC_DIR}/build-linux-i686/packages/lib/release/libaprutil-1.a when searching for -laprutil-1
		/usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld: skipping incompatible ${SRC_DIR}/build-linux-i686/packages/lib/release/libdb-5.1.so when searching for -ldb-5.1
		/usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld: cannot find -ldb-5.1
		collect2: ld returned 1 exit status
		make[2]: *** [llcommon/libllcommon.so] Error 1
		make[1]: *** [llcommon/CMakeFiles/llcommon.dir/all] Error 2
		make: *** [all] Error 2
		ERROR: building default configuration returned 2
		For more information: try re-running your command with --verbose or --debug
	(This is, off course, expected. Will have to produce my own 64bit prebuilts for local use.)

Tried a standalone 64-bit build (after merging OPEN-38 changes):
	Fails by hitting https://jira.secondlife.com/browse/OPEN-100

(Both errors occur much later in the build process than the one that'd occur without this change.)

Tried a non-standalone 32-bit build:
	Fails on https://jira.secondlife.com/browse/OPEN-23 , just as without this change.
Review request changed
Updated (July 10, 2011, 12:59 p.m.)
Added Nyx Linden to reviewers, as OPEN-79 is assigned to him.
Ship it!
Posted (July 12, 2011, 8:45 a.m.)
Looks plausible.