All submissions to this site are governed by the Second Life Viewer Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.

Review Board 1.6.11

Welcome to the Second Life Viewer Code Review tool.
See the documentation on our wiki for how to use this site.

STORM-1392 Add Nearby Voice to the Communicate menu

Review Request #346 - Created June 18, 2011 and submitted

Jonathan Yap Reviewers
2.7.4 viewer
STORM-1392
None viewer-development 
Add Nearby Voice to the Communicate menu.  This is currently activated via the flyout button next to the Speak button.
Clicking menu entry toggles appearance/disappearance of Nearby Voice floater.

Noted that this menu entry is grayed out when voice is off or otherwise not available.
Boroondas Gupte
Posted (June 18, 2011, 4:24 a.m.)

   

  

   

   
    
    
   


  






   







    

     
     

      

       
        

         
          indra/newview/llbottomtray.cpp
          

           (Diff revision 1)

          
         
        

       
       
        
 


        
 


        
 


        
 


        
 


        
 


       
      

     

    

    

     
Wouldn't it be better to set the initial disabledness for all three items here in the XUI-XML with https://wiki.secondlife.com/wiki/Skinning_HowTo/Common_XUI_attributes#enabled rather than in the CPP code?

(Assuming that subsequent setEnabled(voice_status) will override it in either case, so that it can still be toggled.)


     

  

   

   
    
    

   
  1. 
    
    
     
    
      
     
    
     
    Code refactoring this area is a good idea but is outside the narrow scope of this jira.  If some Linden thinks this should be done I will make the changes.
    
    
    
   
    2. 


   
  2. 
    
    
     
    
      
     
    
     
    You're right.
    
    
    
   
    3. 

   


  





    

    

   


  
 




  

 



















 

  




 

 

  
Ship it!

  

  
Boroondas Gupte

  
Posted  (June 18, 2011, 5:56 a.m.)