All submissions to this site are governed by the Second Life Viewer Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.

Review Board 1.6.11

Welcome to the Second Life Viewer Code Review tool.
See the documentation on our wiki for how to use this site.

STORM-1368 Code more defensively when uploading a notecard

Review Request #345 - Created June 17, 2011 and submitted

Stone Linden Reviewers
STORM-1368 alain_linden, jenn
None viewer-development 
This change adds some defensive code around notecard upload, making sure that we have a handle to the notecard editor and a connection to a region and asset system before de-referencing pointers to get upload capabilities.
It compiles!
Review request changed
Updated (June 17, 2011, 4:14 p.m.)

  • None yet.

    It compiles!
Ship it!
Alain Linden
Posted (June 17, 2011, 4:33 p.m.)

   

  

   

   
    
    
   


  






  
 




  

 



















 

  




 

 

  
Ship it!

  

  
Vadim ProductEngine

  
Posted  (June 20, 2011, 8:05 a.m.)

 

 

   

   

  

   

   
    
    
   


  






   







    

     
     

      

       
        

         
          indra/newview/llpreviewnotecard.cpp
          

           (Diff revision 1)

          
         
        

       
       
        
 


        
 


        
 


        
 


        
 


        
 


       
      

     

    

    

     
I think the editor check is redundant, because getChild() always returns a valid non-NULL pointer (to a dummy widget if the specified widget was not found).