All submissions to this site are governed by the Second Life Viewer Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.
Welcome to the Second Life Viewer Code Review tool.
See the documentation on our wiki for how to use this site.
Review Request #338 - Created June 14, 2011 and updated
| Alain Linden | Reviewers | ||
| VWR-24099 | stone.linden, jenn | ||
| None | viewer-development | ||
This is a work around to the bug. If the user selects too many friends to lure with a teleport, he will be warned with a dialog rather than crashing on LLError.
| indra/newview/llviewermessage.cpp (Diff revision 1) |
|---|
Assuming the suggested update to notifications.xml, would need to add: args["LIMIT"] = 250 or equivalent code here.
| indra/newview/skins/default/xui/en/notifications.xml (Diff revision 1) |
|---|
Perhaps: "You attempted to make [OFFERS] teleport offers, which exceeds our limit of [LIMIT]."
Expand AllErica from #xd comments:
18:01 < erica> jenn - does this need to be an error message? instead can we prevent them from
*selecting* > [MAX] # residents and tping them? grey out the TP button, for
example, if the number is over [max]
Passed along this suggestion to alain.
| indra/newview/llviewermessage.cpp (Diff revision 1) |
|---|
Should your size check go inside of the 0 == option if block? Are there other possible values for option that might not make sense to cause the 250-limit-popup to occur?
| indra/newview/skins/default/xui/en/notifications.xml (Diff revision 1) |
|---|
Awkward phrasing, one of Jenn's suggestions looks good.
| indra/newview/llviewermessage.cpp (Diff revision 1) |
|---|
No, it should go before. There's no point in asking the sender if they want to offer teleport if the offer will surely fail.
Other reviews