OPEN-76 Fix autobuild so that --config-file option is honoured by subsequent (possibly recursive) commands
Review Request #335 - Created June 10, 2011 and submitted
Ima Mechanique | Reviewers | ||
viewer | |||
OPEN-76 | alain_linden | ||
None | autobuild |
When running a command such as: autobuild configure --config-file ab-test.xml -c ReleaseOS the configuration is only partially completed correctly. When the installables are processed, it does not use the correct configuration file. This is due to cmake calling autobuild install to do the actual install, but not passing the --config-file option. Autobuild falls back to the default autobuild.xml, because the correct configuration file is not saved at any point, which is not the intention and can cause configuration to be done with incorrect libraries. If autobuild.xml is missing or corrupt, an error occurs (which is how I discovered this), stopping the configure command. This fix saves the current value of the configuration file into the AUTOBUILD_CONFIG_FILE environmental variable so that it becomes the default value should any subsequent command need it. I believe that something like this was the original intention when adding this environment variable as part of the default check, but was overlooked.
Ran 'autobuild configure --config-file ab-test.xml -c ReleaseOS' successfully without any errors and was able to build the expected viewer afterwards.
Posted (June 10, 2011, 2:22 a.m.)
-
autobuild/configfile.py (Diff revision 1) -
I think the environment variable should be set right after this if-else block (which I think is the only place where self.path is set or modified). Otherwise the environment variable might not be set although self.path is set. ... or set the environment variable in __init__, right after the self.__load(path) call.
Review request changed
Updated (June 10, 2011, 2:47 a.m.)
-
- added Diff r2
After discussing with Boroondas on IRC we concluded that __INIT__ is a more sensible place for the environment variable to be set, after __load has finished checking its validity.
Review request changed
Updated (July 22, 2011, 6:35 a.m.)
-
- added alain_linden
Alain... would you please have a look at how this is done?
Other reviews