STORM-899 'No attachments worn' text on blank 'Attachments' accordion remains in English for all locales


Submitter:	Jonathan Yap	Reviewers
Branch:	2.7.2	Groups:	viewer
Bugs:	STORM-899	People:
Change Number:	None	Repository:	viewer-development

Description:

1. Launch viewer, change language to German for example.
2. Re-login, open COF for edit.
3. Open 'Attachments' accordion, delete all objects.
===>
Actual: 'No attachments worn' text appears in English.

Testing Done:

Opened this tab with the viewer in English and also in French.  I saw the same message, but that is because there is no translation for French, but it shows the call for a translation is working.

What I am not sure of is if I made fix in the right way.

Expand All

See minor points below.

indra/newview/llcofwearables.cpp (Diff revision 1)

I suppose this can be done once in postBuild(), because the textbox only gets visible when the list is empty.

indra/newview/skins/default/xui/en/strings.xml (Diff revision 1)

The section this string is in seems inappropriate.

Jonathan Yap June 15, 2011, 10:03 a.m. (June 15, 2011, 10:03 a.m.)

I've moved this a bit farther down and created its own section, as per Vadim's jira comment other similar flatlist fixes may be necessary.

Diff
- added Diff r2

Description:

Made changes per Vadim's comments.

Thanks.

indra/newview/skins/default/xui/en/strings.xml (Diff revision 2)

Is it intentional that each of these 3 lines is indented differently?

Diff
- added Diff r3

Description:

Changed tab to space per Boroondas' comment.

You have a pending review.

Other reviews

Your comment

Review Board 1.6.11

This change has been marked as submitted.