Make sure to set SO_NONBLOCK on sockets whose timeouts are also set to 0.


Submitter:	Stone Linden	Reviewers
Branch:		Groups:
Bugs:	storm-1446	People:	oz.linden, Monty.Linden, kellylinden
Change Number:	None	Repository:	viewer-development

Description:

Make sure to set SO_NONBLOCK, otherwise on Windows the sockets won't actually be non-blocking. See http://dev.ariel-networks.com/apr/apr-tutorial/html/apr-tutorial-13.html#ss13.4

Testing Done:

My viewer works normally on Mac. Mostly this change applies to Windows, given the chart for 0 timeouts without SO_NONBLOCK.

Expand All

Diff
- added Diff r2

Description:

Header file changes to match.

With two suggestions:
1.  Note in the .h that the only portable way to get a block-forever socket is to use a negative timeout value.
2.  Make certain the indra/test/io.cpp unit test is being built and run.  It's the only thing that exercises LLSocket in vitro.

Stone Linden June 7, 2011, 2:28 p.m. (June 7, 2011, 2:28 p.m.)
```
No idea how to do 2. :(
```

Stone Linden June 8, 2011, 12:21 p.m. (June 8, 2011, 12:21 p.m.)

Checked my build logs, and I do not see that io test running in the viewer build. Help appreciated.

Diff
- added Diff r3

Description:

Header file notes per Monty's comment.

Testing Done

Changed from:

None, actually.

Changed to:

My viewer works normally on Mac. Mostly this change applies to Windows, given the chart for 0 timeouts without SO_NONBLOCK.

Bugs Closed
- added storm-1446

Description:

Attach to a bug.

Builds and runs on Linux.  I enabled the io.cpp test after applying the patch and it runs successfully with no failed tests.

You have a pending review.

Other reviews

Your comment

Review Board 1.6.11

This change has been marked as submitted.