VWR-25896 [Regression] Bulk uploads do not adhere to default permissions
Review Request #323 - Created June 5, 2011 and submitted
| Jonathan Yap | Reviewers | ||
| 2.7.2 | viewer | ||
| VWR-25896 | |||
| None | viewer-development | ||
Something in the big mesh branch merge (build 230088) appears to have broken bulk uploading.
* On inventory tab, click "+" menu -> Upload -> Set Default Permissions
* Set your default permissions to enable Next owner Modify, Copy, and Resell/Giveaway and click OK
* Click "+" menu -> Upload -> Bulk and select a group of multiple images
* After upload completes, check permissions of each uploaded item
Expected behavior is that all the bulk uploaded items would have Modify/Copy/Transfer permissions.
Actual results is that first item upload has Modify/Copy/Transfer permissions, all others have no perms at all.
I examined this area of code before the mesh merge and saw a small but significant difference. It is not clear to me that this is the only change necessary; in an email Oz said a server-side change might be needed too.
Repeated bulk uploading of two textures, altering the settings in the bulk upload floater for each test; their uploaded properties followed the settings I had set in the floater.
Expand AllPosted (June 5, 2011, 8:03 a.m.)
-
indra/newview/llassetuploadresponders.cpp (Diff revision 1) -
While you're at it, re-complete this comment that was (probably accidentally) clipped in the same commit (https://bitbucket.org/lindenlab/viewer-development/changeset/8871cfd6eaf5#chg_indra/newview/llassetuploadresponders.cpp_oldline328 )
-
indra/newview/llassetuploadresponders.cpp (Diff revision 1) -
If the original comment is still accurate, your fix should be fine. (The now missing line in the comment explains why mPostData has to be used here rather than content.) However a lot has changed around here, so it's hard to tell whether the original comment would still apply unchanged.
Review request changed
Updated (June 5, 2011, 8:11 a.m.)
-
- added Diff r2
-
indra/newview/llassetuploadresponders.cpp (Diff revision 2) -
No objections, so let's just see whether this works. It'd be nice if whoever did change this from 'mPostData' to 'content' would comment on this fix, but as the commit where that happened seems to lump together many unrelated changes (maybe still from an SVN branch?), it'll be difficult to track down who that even was.
Other reviews