All submissions to this site are governed by the Second Life Viewer Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.

Review Board 1.6.11

Welcome to the Second Life Viewer Code Review tool.
See the documentation on our wiki for how to use this site.

STORM-859 : winres.h isn't present within VC++ Express includes. Must be manually copied from win7 sdk example code.

Review Request #304 - Created May 15, 2011 and submitted

Wolfpup Lowenhar Reviewers
viewer-development viewer
STORM-859
None viewer-development 
This is for switching from using winres.h to windows.h so that the viewer can be build no matter whether your using and Express or Professional version of Visual Studio.
I have built viewer-development locally with this modification using Visual Studio 2010 Ultimate and have seen no ill affects as yet to the built viewer. It logs in to SL just fine.
I have done the following with the built viewer:
1. edited or created objects with no ill affects.
2. carried on conversations in Near By, Group and P2P with no ill affects.
3. Teleported to various sims and levels in those sims with no ill affect.
4. carried on Voice conversations with no ill affect.
5. moved things around in my inventory as well as rezed and taken objects from and to my inventory with no ill affects.
Review request changed
Updated (May 16, 2011, 4:16 a.m.)
sorry use wrong initial diff here is the correct diff
Ship it!
Boroondas Gupte
Posted (May 16, 2011, 5:03 a.m.)
Am I reading this comment right, that ...
indra/newview/res/viewerRes.rc (Diff revision 2) 
 
 
 
 
 
 
 
 
 
... this code here has been generated ...
indra/newview/res/viewerRes.rc (Diff revision 2) 
 
 
 
 
 
 
 
... from the block here (notabene in the same file)?
Assuming so, 'ship it', as your change in and of itself seems good, and you are changing the generating and the generated code consistently. (And other than STORM-1074, we don't seem to be touching code shared with the server, here.)

Though I must say that I am worried about this script/header in general (pre- and post-change equally), as generating code in another part of the same file is damn close to self-modifying code. A concept which, while very powerful and sometimes useful, is usually deemed bad practice or even plain dangerous.

I don't know whether it is considered save, normal and/or accepted for MS Visual C++ resource scripts. Maybe VS has some safeguards to ensure nothing too crazy happens through them?
Ship it!
ardy.lay
Posted (May 16, 2011, 9:36 a.m.)
I think I can approve of that.  It's essentially what we decided on at a meeting.  I think my point was to put the #define in with the rest of them instead of out in left field and this looks good to me now.