All submissions to this site are governed by the Second Life Viewer Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.

Review Board 1.6.11

Welcome to the Second Life Viewer Code Review tool.
See the documentation on our wiki for how to use this site.

STORM-951 Accidental Self-Muting/Self-Blocking

Review Request #303 - Created May 10, 2011 and submitted

Paul ProductEngine Reviewers
viewer
storm-951
None viewer-development
- To avoid self blocking, add blocked object by its ID. 

- Before showing offer from object, check whether this object is blocked, to avoid spamming offers from blocked objects.

 
Posted (May 10, 2011, 10:25 a.m.)

   

  
indra/newview/llnotificationofferhandler.cpp (Diff revision 1)
 
 
 
 
Are you sure this is the right place for such kind of check?

I think it should rather be somewhere in llviewermessage.cpp (maybe process_improved_im()).
indra/newview/llviewermessage.cpp (Diff revision 1)
 
 
please add:
* a reference to the ticket
* a space after //
indra/newview/llviewermessage.cpp (Diff revision 1)
 
 
 
 
 
 
 
 
 
 
I'm not quite getting why there are two code paths for calling inventory_offer_mute_callback(), i.e. why not write it like this:

===
LLUUID sender_id;

if (mFromObject)
{
	const LLUUID& object_id = notification_ptr->getPayload()["object_id"].asUUID();
	sender_id = object_id;
}
else
{
	sender_id = mFromID;
}

gCacheName->get(sender_id, mFromGroup, boost::bind(&inventory_offer_mute_callback,_1,_2,_3,notification_ptr->getResponderPtr()));
===

And please move the comments to the lines where the corresponding conditions are.