All submissions to this site are governed by the Second Life Viewer Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.

Review Board 1.6.11

Welcome to the Second Life Viewer Code Review tool.
See the documentation on our wiki for how to use this site.

Modify Viewer to statically link to KDU v6.4.1 if available

Review Request #3 - Created Dec. 3, 2010 and submitted

Merov Linden Reviewers
viewer
STORM-151
None viewer-development 
This rather big patch accomplish the following:
- makes llkdu public and open source: this contains decompression and compression implementations using the KDU API
- links the viewer to KDU v6.4.1 statically if USE_KDU set at build time (and assuming you do have a licensed version of Kakadu)
- links statically to OpenJpeg otherwise

 

 










  

 
















 














 

  




 

   

   
Review request changed

   
Updated  (Dec. 15, 2010, 10:21 p.m.)

 

 

  

  
  
Took Oz's comment into account (suppressed unused code) + code formatting 


 




  

 
















 

  




 

 

  
Ship it!

  

  
Vadim ProductEngine

  
Posted  (Dec. 20, 2010, 9:40 a.m.)

 

 

   
No significant objections. (I didn't actually review llimagej2c.cpp: it would take forever :-))

Tested x86 Linux build with USE_KDU set to ON and OFF. Works fine with the patch I attached to the ticket.

   

  

   

   
    
    
   


  






   







    

     
     

      

       
        

         
          indra/cmake/Copy3rdPartyLibs.cmake
          

           (Diff revision 2)

          
         
        

       
       
        
 


        
 


        
 


        
 


        
 


        
 


        
 


       
      

     

    

    

     
I didn't quite get why there are FMOD-related changes in this patch.


     

  

   

   
    
    
   


  





    

    

    

     
     

      

       
        

         
          indra/llkdu/llkdumem.h
          

           (Diff revision 2)

          
         
        

       
       
        
 


        
 


        
 


        
 


        
 


        
 


        
 


        
 


        
 


       
      

     

    

    

     
CS: mFirstCompIdx, mNumComponents, etc.