All submissions to this site are governed by the Second Life Viewer Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.

Review Board 1.6.11

Welcome to the Second Life Viewer Code Review tool.
See the documentation on our wiki for how to use this site.

CHOP-629 symbol information for llcommon.dll is missing both in the debugger and in crash reports

Review Request #281 - Created April 26, 2011 and submitted

Brad Kittenbrink Reviewers
viewer
CHOP-629
None viewer-development 
Somewhere in the VS2010 transition, the default conventions changed for how .pdb files get generated on shared library targets.  This fix explicitly sets the /DEBUG flag for the linker on the llcommon target.
I tested locally in the debugger, but I did not test crash reports.  We should find a way to test that once my TC build completes.
Boroondas Gupte
Posted (April 27, 2011, 2:16 a.m.)

   

  

   

   
    
    
   


  






   







    

     
     

      

       
        

         
          indra/llcommon/CMakeLists.txt
          

           (Diff revision 1)

          
         
        

       
       
        
 


        
 


        
 


        
 


        
 


        
 


        
 


        
 


        
 


        
 


        
 


        
 


        
 


        
 


        
 


        
 


        
 


        
 


       
      

     

    

    

     
Naive question: Is there a reason not to add /DEBUG also when NOT LLCOMMON_LINK_SHARED?


     

  

   

   
    
    

   
  1. 
    
    
     
    
      
     
    
     
    The /DEBUG linker flag doesn't really apply for static libraries since the linker doesn't run for static libraries on windows.  The debug information is already embedded in our .lib static libraries on windows.
    
    
    
   
    2. 

   


  





    

    

   


  
 




  

 



















 

  




 

 

  
Ship it!

  

  
Boroondas Gupte

  
Posted  (April 27, 2011, 11:38 a.m.)

 

 

   
>    The /DEBUG linker flag doesn't really apply for static libraries since the linker doesn't run for static libraries on windows.  The debug information is already embedded in our .lib static libraries on windows.

Ah, ok.