STORM-1103 Nearby sidebar minimap should be optional
Review Request #265 - Created April 14, 2011 and submitted
Twisted Laws | Reviewers | ||
viewer | |||
STORM-1103 | |||
None | viewer-development |
Patch makes the map in the Nearby people tab optional with a menu option in the gear menu. Patch is XML only and resizing of the map is disabled (user_resize="false" in the layout_panels) as I could not find a way to easily save window sizes purely in XML. Patch is in the repository of https://bitbucket.org/Twisted_Laws/viewer-development-storm-1103 as https://bitbucket.org/Twisted_Laws/viewer-development-storm-1103/changeset/3455e79a14af and https://bitbucket.org/Twisted_Laws/viewer-development-storm-1103/changeset/48b66643a4d1
Tested by exercising the gear menu option of "View Map" with the People tab attached and detached insuring the map appears and disappears properly.
Already giving a 'Ship it', as all my comments below address very minor stuff.
-
indra/newview/app_settings/settings.xml (Diff revision 1) -
<nitpick> Technically, this doesn't show the (main) Map, but an (additional) Mini-Map. And that isn't in the nearby people list, but above it. </nitpick> So maybe make this <string>Show/hide additional mini-map above nearby list</string> or <string>Show/hide additional mini-map in 'Nearby People' sidepanel</string> (... or not. Once people try it, it should be clear enough. And hopefully most will prefer using the gear menu over altering the debug setting manually.)
-
indra/newview/skins/default/xui/en/panel_people.xml (Diff revision 1) -
Are the 'top' and 'left' attributes really needed? I guess they default to 0 anyway when omitted ...
-
indra/newview/skins/default/xui/en/panel_people.xml (Diff revision 1) -
<net_map /> is inside <layout_panel />, so it should be indented one level more.
-
indra/newview/skins/default/xui/en/panel_people.xml (Diff revision 1) -
<avatar_list /> is inside <layout_panel />, so it should be indented one level more.
-
indra/newview/skins/default/xui/en/panel_people.xml (Diff revision 1) -
I'd prefer to have the attributes ordered semantically (i.e. 'name' first, 'top' and 'left' right after each other, 'height' and 'width' right after each other etc.) rather than alphabetically. But as the surrounding code also seems to have its attributes ordered alphabetically, we might as well stick to that. Though, then, keep_one_selected should be moved up.
Looks fine and works well for me, however I don't quite understand why to limit your changes with XML files. Resizing the mini-map might improve usability.
-
indra/newview/app_settings/settings.xml (Diff revision 1) -
I'd say "nearby people list", not "nearby list".
-
indra/newview/skins/default/xui/en/menu_people_nearby_view_sort.xml (Diff revision 1) -
I'd say "View Mini-Map": by "Map" we usually mean the world map, which is obviously a different thing.
-
indra/newview/skins/default/xui/en/panel_people.xml (Diff revision 1) -
Reformat with alphabetic parameter order and place one parameter per line. That's more diff-friendly and also improves compatibility with the XUI preview tool.
-
indra/newview/skins/default/xui/en/panel_people.xml (Diff revision 1) -
This looks like irrelevant change.
Review request changed
Updated (April 15, 2011, 11:46 a.m.)
-
- added Diff r2
revised patch is attached, repository updated
-
indra/newview/skins/default/xui/en/panel_people.xml (Diff revisions 1 - 2) -
Put a space before the "/>" and it's perfect, I'd say.
(I cannot tell whether all the numbers for the positioning attributes make sense, but I guess you would have noticed while testing if not.)
Review request changed
Updated (May 14, 2011, 1:07 p.m.)
-
Patch makes the map in the Nearby people tab optional with a menu option in the gear menu. Patch is XML only and resizing of the map is disabled (user_resize="false" in the layout_panels) as I could not find a way to easily save window sizes purely in XML. Patch is in the repository of https://Twisted_Laws/viewer-development-storm-1103 as https://bitbucket.org/Twisted_Laws/viewer-development-storm-1103/changeset/3455e79a14af
Patch makes the map in the Nearby people tab optional with a menu option in the gear menu. Patch is XML only and resizing of the map is disabled (user_resize="false" in the layout_panels) as I could not find a way to easily save window sizes purely in XML. Patch is in the repository of https://bitbucket.org/Twisted_Laws/viewer-development-storm-1103 as https://bitbucket.org/Twisted_Laws/viewer-development-storm-1103/changeset/3455e79a14af and https://bitbucket.org/Twisted_Laws/viewer-development-storm-1103/changeset/48b66643a4d1
corrected a bad url to the repository in my description and added the second changeset url
work fine on linux, nothing "evil" visible after some time of usage.
Review request changed
Updated (June 26, 2011, 8:32 a.m.)
-
- added Diff r3
Corrects an issue identified in JIRA STORM-1103 where it is possible to make it so the map can no longer be displayed. Quoted from JIRA 1. Open Nearby Panel 2. Decrease viewer window height until mini-map disappears automatically 3. Disable mini-map in the gear menu 4. Maximize viewer window height 5. Enable minim-map via gear menu Actual Results Minimap isn't displayed without this patch. With this patch, the Minimap is still displayable.
Other reviews