All submissions to this site are governed by the Second Life Viewer Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.

Review Board 1.6.11

Welcome to the Second Life Viewer Code Review tool.
See the documentation on our wiki for how to use this site.

(STORM-1042) Disabled 'Save' button at the 'Create Landmark' panel

Review Request #261 - Created April 8, 2011 and submitted

Seth ProductEngine Reviewers
viewer
STORM-1042
None viewer-development
Fixed the inventory observers of newly added items.

The problem was caused by an outdated message name stored in LLInventoryObserver::mMessageName and not updated properly in LLInventoryModel::notifyObservers(). 
The message name used in LLInventoryAddedObserver::changed() was the name of the message most recently passed by LLInventoryModel::notifyObservers(), instead of the name of the latest actually received message. Using the most recent message name in this case fixed the problem.

 
Review request changed
Updated (April 11, 2011, 9:27 a.m.)
  • Fixed the inventory observers of newly added items.
    
    Removed pieces of code marked as fix for DEV-20328 but could not check for the regression.

    Fixed the inventory observers of newly added items.
    
    The problem was caused by an outdated message name stored in LLInventoryObserver::mMessageName and not updated properly in LLInventoryModel::notifyObservers(). 
    The message name used in LLInventoryAddedObserver::changed() was the name of the message most recently passed by LLInventoryModel::notifyObservers(), instead of the name of the latest actually received message. Using the most recent message name in this case fixed the problem.
Ship it!
Posted (April 11, 2011, 9:28 a.m.)