All submissions to this site are governed by the Second Life Viewer Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.

Review Board 1.6.11

Welcome to the Second Life Viewer Code Review tool.
See the documentation on our wiki for how to use this site.

OPEN-61 Adding locations that VC redistributable package installs files.

Review Request #259 - Created April 8, 2011 and submitted

Ima Mechanique Reviewers
viewer
OPEN-61
None viewer-development
The VC redistributable package installs its files (msvcr100.dll, msvcp100.dll, msvcr100d.dll, msvcp100d.dll, etc.) to the WINDOWS\System32 directory (and WINDOWS\SysWOW64, if it is a 64-bit version). Adding these locations to the list of places to look when attempting to copy the files to build-vc100\sharedlibs.

On 64 bit windows the 32-bit file versions go to SySWOW64, so this is listed first to prevent the 64-bit versions being used.

If any one knows how it could use %systemroot% instead of the environment variable WINDIR I'd appreciate the info ;-) 
Ran 'autobuild build' without manually copying the redistributable files or adding the configure switch to point at their location.
Review request changed
Updated (April 21, 2011, 2:18 p.m.)
updated diff
Ship it!
Posted (April 21, 2011, 7:46 p.m.)
Seems to have worked for me on Windows 7 64-bit.  Thanks!
Ship it!
Posted (April 21, 2011, 8:25 p.m.)
Works Great!
Ship it!
Posted (April 28, 2011, 11:41 a.m.)
Looks good. I'll run that through a test TC build before merging though...