All submissions to this site are governed by the Second Life Viewer Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.

Review Board 1.6.11

Welcome to the Second Life Viewer Code Review tool.
See the documentation on our wiki for how to use this site.

Crash in LLVivoxVoiceClient::notifyStatusObservers()

Review Request #25 - Created Dec. 15, 2010 and submitted

Kitty Barnett Reviewers
viewer
VWR-24209
None viewer-beta 
Moved removeObserver() out of the "if(getAvatarId().notNull()) { }" block since "getAvatarId()" can return the NULL UUID (i.e. if the panel hasn't been opened), matching the addObserver() without condition in postBuild.

 

 










  

 


















 

  




 

 

  
Ship it!

  

  
Merov Linden

  
Posted  (Dec. 16, 2010, 9:29 a.m.)

 

 

   
This looks correct to me and should fix the observed crasher.