(STORM-941) IM log naming should go by SL name, not DN.
Review Request #249 - Created April 4, 2011 and submitted
| Seth ProductEngine | Reviewers | ||
| viewer | |||
| STORM-941 | |||
| None | viewer-development | ||
Fixed IM history to use the resident's user name for the log file name. Added conversions from legacy names or SLURLs with avatar id to the user names in cases of logging P2P sessions and inventory offers. Removed asynchronous writes to temporary IM log file depending on name cache responses.
Expand AllPosted (April 5, 2011, 8:48 a.m.)
Looks fine, except for two issues.
-
indra/llui/llurlaction.h (Diff revision 1) -
I don't agree that LLURLAction as an appropriate place for this method: the method does no user-visible action ant thus should be moved to an auxiliary class (not sure which one, needs investigation).
-
indra/newview/llimview.cpp (Diff revision 1) -
What happens to messages logged in between the call to buildUserName() and the moment when the name gets asynchronously refreshed by onAvatarNameCache()? It looks like the messages may be logged to a different file than subsequent ones. If that's the case, maybe the old file should be renamed once you've got the updated name?
Posted (April 5, 2011, 9:02 a.m.)
-
indra/llui/llurlaction.h (Diff revision 1) -
Having this here looks to be the best way to prevent generating a Legacy named P2P system message during said conversation that has been started by a person that DOSE NOT have Display Names turned on as there is one SYSTEM message that would seem to be coming from no where and this looks like it is its source.
Review request changed
Updated (April 7, 2011, 4:16 p.m.)
-
- added Diff r2
Fixed resolving IM session participants names prior to writing messages to the log file to avoid temporary log files which could possibly appear if user names were not resolved before the first message had been written to the log.
Posted (April 11, 2011, 8:39 a.m.)
-
indra/newview/llimview.cpp (Diff revision 2) -
This looks even worse than the original fix: AFAIU, until the name is resolved, IMs won't be saved at all.
Review request changed
Updated (April 13, 2011, 8:11 a.m.)
-
- added Diff r3
-
Fixed IM history to use the resident's user name for the log file name. Added conversions from legacy names or SLURLs with avatar id to the user names in cases of logging P2P sessions and inventory offers.
Fixed IM history to use the resident's user name for the log file name. Added conversions from legacy names or SLURLs with avatar id to the user names in cases of logging P2P sessions and inventory offers. Removed asynchronous writes to temporary IM log file depending on name cache responses.
Removed asynchronous writes to temporary IM log file depending on name cache responses. Looks like there is no need for requesting names from cache or the name is already in cache in some cases, so no need for a callback.
Other reviews