Improved error messages for configuration errors.
Review Request #248 - Created April 1, 2011 and submitted
| Alain Linden | Reviewers | ||
| CHOP-180 | oz.linden, brad.linden, jenn, nat_linden | ||
| None | autobuild | ||
Improved error messages in response to CHOP-180.
Expand AllLooks good.... (by the way, please fill in the Bugs field with the jira issue id; it becomes a link automatically)
Review request changed
Updated (April 1, 2011, 12:02 p.m.)
-
- added CHOP-180
Looks good to me!
Posted (April 1, 2011, 1:27 p.m.)
I notice that new lines 108-112 in get_build_directory() exactly duplicate new lines 141-145 in get_platform() -- maybe make get_build_directory() call get_platform() instead of requiring parallel maintenance?
Review request changed
Updated (April 1, 2011, 3:12 p.m.)
-
- added Diff r2
Refactored get_build_directory to eliminate duplicate code. Good catch nat.
Other reviews