All submissions to this site are governed by the Second Life Viewer Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.

Review Board 1.6.11

Welcome to the Second Life Viewer Code Review tool.
See the documentation on our wiki for how to use this site.

STORM-323: redundant popups

Review Request #230 - Created March 24, 2011 and submitted

Lance Corrimal Reviewers
viewer
storm-323
None viewer-development 
Fixed the redundant "You have accepted suchandsuch from soandso" popups that had to actually be confirmed by clicking OK by changing the popup type to SystemMessageTip.
I have been using this patch in my V2 based TPV (Dolphin Viewer 2) since mid-december 2010 without any problems on Windows, Mac OS X and Linux. Does that count as testing? ;)
Review request changed
Updated (March 24, 2011, 4:34 a.m.)
fixing link to jira
Ship it!
Oz Linden
Posted (March 24, 2011, 4:37 a.m.)

   

  

   

   
    
    
   


  






  
 




  

 



















 

  




 

 

  
Ship it!

  

  
Boroondas Gupte

  
Posted  (March 24, 2011, 6:01 a.m.)

 

 

   
Looks good.

Not your fault, but I can't resist to mention the ...

   

  

   

   
    
    
   


  






   







    

     
     

      

       
        

         
          indra/newview/llviewermessage.cpp
          

           (Diff revision 1)

          
         
        

       
       
        
 


        
 


        
 


        
 


        
 


        
 


        
 


        
 


       
      

     

    

    

     
... exact (apart from indentation level) ...


     

  

   

   
    
    
   


  





    

    

    

     
     

      

       
        

         
          indra/newview/llviewermessage.cpp
          

           (Diff revision 1)

          
         
        

       
       
        
 


        
 


        
 


        
 


        
 


        
 


        
 


        
 


       
      

     

    

    

     
... code duplication.