Storm-1077 Change "Voice Enabled/Disabled" to "Speak Button"


Submitter:	Jonathan Yap	Reviewers
Branch:	2.6	Groups:	viewer
Bugs:	STORM-1077	People:
Change Number:	None	Repository:	viewer-development

Description:

1) Change Voice Enabled to Speak Button when you right click on the bottom bar and get a menu.

2) Eliminate the separator bar in this menu.

3) Have a hint appear for the Speak button (see image in jira) the first time you use the viewer, have voice on (the default), and successfully connect to a voice server.

Testing Done:

Expand All

I think that pressing the Speak button or the fly-out button should hide the hint: this is the way how e.g. the Move button hint works.
Otherwise the hint obscures the NEARBY VOICE panel which looks pretty weird.

indra/newview/skins/default/xui/en/notifications.xml (Diff revision 1)

I guess you meant that *voice* is enabled by default, not microphone.

Mic only gets enabled explicitly by pressing the Speak button or middle mouse button.

Jonathan Yap March 24, 2011, 7:10 a.m. (March 24, 2011, 7:10 a.m.)

My message about the mic being on by default is correct.  I asked Q about this and he said it was a design decision.  Every new user has their mic on when they first start the viewer.  Then they wonder why no one writes back when they are using text chat; they have been muted.

See the xml code block that shows the mic is on by default in one of my jira comments for this issue.

Vadim ProductEngine March 24, 2011, 7:17 a.m. (March 24, 2011, 7:17 a.m.)

Right, it says "EnableVoiceChat". This is not the same as "enable microphone".
The difference is that you can have voice chat enabled and thus hear others speak, but your mic will be off until you press Speak.

I tried wiping my Second Life settings (emulating first run) and made sure that by default voice chat is enabled while mic isn't.

Diff
- added Diff r2

Description:

Updated hint wording -- the speak button is NOT on by default.

Disable hint if speak or flyout button is pressed.

Looks good now. I only have one question, see below.

indra/newview/llcallfloater.cpp (Diff revision 2)

redundant change

indra/newview/llspeakbutton.cpp (Diff revision 2)

Why do you do this again on mouse up as well?
Isn't it enough to dismiss the hint on mouse down only?

I deleted the line in the mouse-up speak button code that turns off the speak button hint.  That line was there when I incorrectly though the speak button might be on at viewer startup.  I could not get the diff to update so am commenting in here.

Jonathan Yap March 24, 2011, 11:04 a.m. (March 24, 2011, 11:04 a.m.)
```
You can look at the bitbucket repo to see the change.
```

No more objections. Thanks, Jonathan!

To avoid problems with uploading modified diffs, try using cumulative diffs, i.e. each uploaded diff includes all changes from the previous one.
Thus you can use Review Board to see differences between the diffs, and each diff is perfectly useful and self-contained.

You have a pending review.

Other reviews

Your comment

Review Board 1.6.11

This change has been marked as submitted.