All submissions to this site are governed by the Second Life Viewer Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.

Review Board 1.6.11

Welcome to the Second Life Viewer Code Review tool.
See the documentation on our wiki for how to use this site.

Suggested fix for OPEN-45

Review Request #215 - Created March 17, 2011 and submitted

Alain Linden Reviewers
viewer
OPEN-45 oz.linden, boroondas.gupte
None autobuild
Suggested fix for OPEN-45.  I'd like to decouple Executable as much as possible from assumptions and state of autobuild.  To that end I added an optional argument to the __str__ method to accept an options list to insert into the command string.  The command string generated by __call__ and __str__ is now identical.  Incidentally I made the environment an optional argument to __call__ to make it more general and decouple it a little more from the rest of autobuild.

 
Review request changed
Updated (March 17, 2011, 3:02 p.m.)
Ship it!
Posted (March 17, 2011, 5:05 p.m.)
Even better than my solution