Suggested fix for OPEN-45
Review Request #215 - Created March 17, 2011 and submitted
Alain Linden | Reviewers | ||
viewer | |||
OPEN-45 | oz.linden, boroondas.gupte | ||
None | autobuild |
Suggested fix for OPEN-45. I'd like to decouple Executable as much as possible from assumptions and state of autobuild. To that end I added an optional argument to the __str__ method to accept an options list to insert into the command string. The command string generated by __call__ and __str__ is now identical. Incidentally I made the environment an optional argument to __call__ to make it more general and decouple it a little more from the rest of autobuild.
Posted (March 17, 2011, 2:25 p.m.)
Consider adding "viewer" as reviewing group, so that the opensource-dev mailing list will get automatic mails.
Review request changed
Updated (March 17, 2011, 3:02 p.m.)
-
- added viewer
Other reviews