All submissions to this site are governed by the Second Life Viewer Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.

Review Board 1.6.11

Welcome to the Second Life Viewer Code Review tool.
See the documentation on our wiki for how to use this site.

Use of local packaged FMOD libs in viewer-autobuild

Review Request #201 - Created March 14, 2011 and submitted

Merov Linden Reviewers
https://bitbucket.org/merov_linden/viewer-autobuild-open-4 viewer
STORM-1022, STORM-1023
None oz_linden/viewer-autobuild 
This changes allows a local fmod package (created using 2p-fmod) to be used to build viewer-autobuild. It allows also local paths to be specified as an alternative though that option doesn't work for Windows due to further complications in manifest and libraries being copied around.

LLKDU.cmake has also be modified to use the same logic as fmod since it could be in the same category (assuming a TPV dev has a local kdu package and wants to build with USE_KDU).

The Prebuilt.cmake change is a simple refactorization no-op, making the code more clear: the USE_PROPRIETARY "if/else" code differences related to scp where commented out.
Build commands tested (use autobuild.cmd on Windows):
- autobuild configure -c OpenSourceRelWithDebInfo : Builds on both Mac and Windows, builds a viewer with no sound capability 
- autobuild configure -c OpenSourceRelWithDebInfo -- -DFMOD:BOOL=ON -DFMOD_LIBRARY:PATH=<full_path_to_fmod.dll> -DFMOD_INCLUDE_DIR : BuildsWorks on Mac but not on Windows.
- autobuild configure -c OpenSourceRelWithDebInfo -- -DFMOD:BOOL=ON: Builds on both Mac and Windows if path to fmod package in autobuild.xml is changed to point to a local file:///<path>.tar.gz

Linux builds: not tested