All submissions to this site are governed by the Second Life Viewer Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.

Review Board 1.6.11

Welcome to the Second Life Viewer Code Review tool.
See the documentation on our wiki for how to use this site.

STORM-987 : llimage_libtest : create an independent executable to exercise llimage outside the viewer

Review Request #195 - Created March 9, 2011 and submitted

Merov Linden Reviewers
https://merov_linden@bitbucket.org/merov_linden/viewer-development-storm-987 viewer
STORM-987
None viewer-development
This creates a new independent executable that exercise the entire llimage libray, loading and saving all supported image file formats, gathering perf data and outputting basic image info.

The use of the application itself is documented in the wiki: https://wiki.secondlife.com/wiki/Llimage_libtest

From a code standpoint, the main things done are:
- Add a new test application in indra/integration_tests/llimage_libtest/
- Move some perf amalyzing code from indra/newview/llfasttimerview.cpp to indra/llcommon/llmetricperformancetester so that it can be used outside the newview context (as it should...)
- Small cleanup in llimage.h
So far, testing has been done on Mac only. Tests on Windows and Linux are planned and will likely result in cmake tweaks here and there. We're not planning however to alter dramatically this code further at this point.
Review request changed
Updated (March 10, 2011, 10:15 p.m.)
Took Vadim's private comments into account:
- added more arguments consistency checking
- flushed perf data when done with images so that there's something in the slp file, even for small amount of data analyzed
Posted (April 5, 2011, 12:43 p.m.)
Sorry, I haven't had time to investigate the build issue further.
Anyway, the code has been integrated. Please close the review request.