All submissions to this site are governed by the Second Life Viewer Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.

Review Board 1.6.11

Welcome to the Second Life Viewer Code Review tool.
See the documentation on our wiki for how to use this site.

STORM-954 corrected patch

Review Request #194 - Created March 9, 2011 and submitted

Twisted Laws Reviewers
viewer
storm-954
None viewer-development
STORM-954 review had 2 patches, the second of which was approved in review process but the first patch is what went into viewer-development.  This is that second patch again. This patch modifies getAvatars() in llworld.cpp.  Note this patch becomes more important if/when avatar distances may be displayed to users in the viewer as it corrects for map data being incorrect above 1024m by using the viewer characters list to get avatar position if known and then falling back on the map data for the avatars that are beyond view range.  This patch is in the repository https://bitbucket.org/Twisted_Laws/viewer-development-storm-954
Proper testing with and without this patch is to have 2 or more avatars at 1050 height with other avatars on the ground under you, and the NearmeRange (debug setting) set to 4096 and the sort order in the Nearby avatars panel set to sort by distance. (A busy region like a sandbox, is a good place to test.) Without this patch, a nearby avatar will not necessarily be displayed before avatars that are further away.  With this patch, the avatar standing closest to you should show up as the first in the list.   
Review request changed
Updated (March 9, 2011, 3:33 p.m.)
Posted (March 31, 2011, 12:24 p.m.)
+1 on this patch modulo the code convention fix I mention here under.
  1. Corrected and updated in https://bitbucket.org/Twisted_Laws/viewer-development-storm-954/changeset/7bcb336642f4 (the braces changes only)
indra/newview/llworld.cpp (Diff revision 1)
 
 
 
 
 
 
Code convention: could you add "{}" around the statements following these "if"s?
indra/newview/llworld.cpp (Diff revision 1)
 
 
 
 
 
Funny that you added them here :)
Ship it!
Posted (March 31, 2011, 2:12 p.m.)
Thanks Twisted for taking my comment into account in https://bitbucket.org/Twisted_Laws/viewer-development-storm-954/changeset/7bcb336642f4

This is ready to be pull in as far as I'm concerned.