All submissions to this site are governed by the Second Life Viewer Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.

Review Board 1.6.11

Welcome to the Second Life Viewer Code Review tool.
See the documentation on our wiki for how to use this site.

one-line fix for OPEN-39: (standalone) bitpack_test.o: No such file or directory

Review Request #168 - Created Feb. 26, 2011 and submitted

Boroondas Gupte Reviewers
viewer
OPEN-39 Aleric.Inglewood
None viewer-development 
On standalone, -I"${TUT_INCLUDE_DIR}" was added to the compile flags for integration tests of llcommon when TUT_INCLUDE_DIR might not have been set yet. This lead to a flag -I"", which would confuse g++ and lead to the tests' object files not being found.

This change makes sure that TUT_INCLUDE_DIR is set by including Tut.cmake, which is responsible for setting it.
Clean rebuild with LL_TESTS ON (see also repro instructions on jira)
Review request changed
Updated (March 2, 2011, 5:32 a.m.)
  • changed from on-line fix for OPEN-39: (standalone) bitpack_test.o: No such file or directory to one-line fix for OPEN-39: (standalone) bitpack_test.o: No such file or directory 
(fixed typo in summary)