OPEN-38: autobuild support for StandAlone
Review Request #167 - Created Feb. 26, 2011 and submitted
Aleric Inglewood | Reviewers | ||
viewer | |||
OPEN-38 | |||
None | oz_linden/viewer-autobuild |
Oz: please merge into your repository.
configures, compiles, runs.
Posted (Feb. 26, 2011, 2:44 p.m.)
Can you give some instructions on how to do a standalone build with these changes? I tried the following: patch -p1 < /home/das-g/slsrc/patches/autobuild-standalone.diff autobuild install glh_linear autobuild configure -c OpenSourceStandAloneRelWithDebInfo but this fails with: CMake Error at cmake/FindGLH.cmake:26 (message): Could not find GLH Thanks
Ah, with that, configuration succeeds and GLH_INCLUDE_DIR gets correctly set to the dir with the symlinks. Could the need for that symlink dir be avoided by having the user directly set the GLH_INCLUDE_DIR CMake variable?
-
indra/cmake/Linking.cmake (Diff revision 1) -
I thought the removal of the NOT STANDALONE condition here would give standalone the same (repository-local) include directories that non-standalone has, so that it'd find autobuild-installed dependencies. But it seems those are just for the library binaries? Or is this just about the creation of those directories, not their addition to the search path?
Building still fails for me, with Linking CXX shared library libllcommon.so /usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld: skipping incompatible /usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../libbreakpad_client.so when searching for -lbreakpad_client /usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld: skipping incompatible /usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../libbreakpad_client.a when searching for -lbreakpad_client /usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld: skipping incompatible /usr/lib/libbreakpad_client.so when searching for -lbreakpad_client /usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld: skipping incompatible /usr/lib/libbreakpad_client.a when searching for -lbreakpad_client /usr/lib/gcc/x86_64-pc-linux-gnu/4.4.5/../../../../x86_64-pc-linux-gnu/bin/ld: cannot find -lbreakpad_client collect2: ld returned 1 exit status make[2]: *** [llcommon/libllcommon.so] Error 1 make[1]: *** [llcommon/CMakeFiles/llcommon.dir/all] Error 2 make[1]: *** Waiting for unfinished jobs.... and In file included from /usr/include/curl/curl.h:36, from [...]/indra/llmessage/llcurl.h:39, from [...]/indra/llmessage/llurlrequest.h:42, from [...]/indra/llmessage/llhttpclient.h:38, from [...]/indra/llmessage/message.h:53, from [...]/indra/llinventory/llcategory.cpp:30: /usr/include/curl/curlrules.h:144: error: size of array ‘__curl_rule_01__’ is negative /usr/include/curl/curlrules.h:154: error: size of array ‘__curl_rule_02__’ is negative but I guess those are both 32bit/64bit issues and not related to your changes here, so "Ship it!".
work on debian/sid 32bit, imho "ship it"
Other reviews