(STORM-28) As a User, I want the ability to send my calling card to others


Submitter:	Seth ProductEngine	Reviewers
Branch:		Groups:	viewer
Bugs:	STORM-28	People:
Change Number:	None	Repository:	viewer-development

Description:

- Added creating own calling card for the user to be able to share it with other residents.
- Moved calling cards synchronization with friends list to the viewer start up. Previously synchronized upon opening the Friends tab in People side panel.
- Calling cards for non-friends are not removed upon calling cards synchronization with friends list.
- Enabled "Share" menu item for calling cards in inventory.

Testing Done:

Expand All

Reduces code and a great feature. I remember going in world multiple, making friends with my alt coping cards and sending calling cards back across inventory to get copies. So, in that respect it saves bandwidth.

Looks good, except for a seemingly redundant code piece.

indra/newview/llpanelpeople.cpp (Diff revision 1)

What do you need the buddies_uuids for?
It seems redundant to me.

Never mind, now I see that the buddies_uuids vector is actually used.

I've nothing against lazy evaluation (I actually like that) but I don't like "static bool" showing up in the middle of the code to execute a piece of initialization once. Is that really something that should be done *once* per instance of the application or *once* per instantiation of the object? I'd prefer to have that synchronization done in the constructor or in an init method or at least have the bool a class or object member (as adequate) that's set to true on instantiation.

Seth ProductEngine March 2, 2011, 9:04 a.m. (March 2, 2011, 9:04 a.m.)

The code with "static bool" is not new, I've just moved it to sync the calling card with friends list on viewer start up.

LLInventoryFriendCardObserver::changed() is used to make sure the inventory became usable since the viewer had started, so this is not a part of LLInventoryFriendCardObserver initialization but rather an action that should be taken once per viewer session.

When working on the patch I didn't replace this static with a member because it was not meant to be used elsewhere.

indra/newview/llpanelpeople.cpp (Diff revision 1)

Please, spell "synchronize" correctly: synchronize_friends_folders

Diff
- added Diff r2

Description:

Corrected spelling.

You have a pending review.

Other reviews

Your comment

Review Board 1.6.11

This change has been marked as submitted.