Nearby chat history is displaying both Display Names and user.names when the Display Name is not changed from default.


Submitter:	ardy.lay	Reviewers
Branch:		Groups:	viewer
Bugs:	VWR-24917	People:
Change Number:	None	Repository:	viewer-development

Description:

https://jira.secondlife.com/browse/VWR-24917
I have been finding the redundent display of functionally equivalent names in nearby chat history and IM history quite tiresome.
Simple proposal: If the resident's Display Name is at the default then do not display their user.name.
https://bitbucket.org/ArdyLay/viewer-development-vwr-24917

Change is to: LLAvatarName::getCompleteName

I find the following Callers:
LLAvatarActions::requestFriendshipDialog
LLAvatarActions::startIM
LLAvatarActions::startCall
LLIMModel::LLIMSession
LLIMModel::logToFile
LLPostponedNotification::onAvatarNameCache
LLUrlEntryAgent::onAvatarNameCache
LLUrlEntryAgent::getLabel
LLUrlEntryAgentCompleteName::getName

// Callback for name resolution of a god/estate message
llviewermessage.cpp(2149): args["NAME"] = av_name.getCompleteName();
llviewermessage.cpp(2154): chat.mText = av_name.getCompleteName() + ": " + message;

static void on_avatar_name_cache_toast ...
llimview.cpp(108): args["FROM"] = av_name.getCompleteName();

Some of these make me wonder if this change will cause some defects and should be implimented as a seperate function.

Testing Done:

I have been using this trivial change and have shared it with a friend, via bitbucket.  We have both built the viewer on Windows 7 and find the resulting reduction in redundent text in chat and IM history on screen to be very helpful.

Expand All

Twisted Laws March 1, 2011, 5:30 p.m. (March 1, 2011, 5:30 p.m.)

Works as advertised for me in use in world and I've not found any adverse effects.   Aleric's rewriting (with comment) makes the most sense.

indra/llcommon/llavatarname.cpp (Diff revision 1)

This could be shortened to

	if (!mUsername.empty() && !mIsDisplayNameDefault)
	{
		name = mDisplayName + " (" + mUsername + ")";
	}
	else
	{
		// Display names are off, so legacy name is in mDisplayName,
		// or Display Name is not changed from (user name based)
		// default, so also showing the user name would be redundant.
		name = mDisplayName;
	}

but I guess the nested ifs make the intention more clear, so go for it.

Aleric Inglewood Feb. 27, 2011, 8:57 a.m. (Feb. 27, 2011, 8:57 a.m.)

Or even more readable(?):

	if (mIsDisplayNameDefault || mUsername.empty())
	{
		// Showing the user name when Display Names are off
                // is redundant, since in that case it's the same string.
		name = mDisplayName;
	}
	else
	{
		name = mDisplayName + " (" + mUsername + ")";
	}

ardy.lay March 4, 2011, 4:46 a.m. (March 4, 2011, 4:46 a.m.)
```
I think this is better to read.  Thanks Aleric.
```

Diff
- added Diff r2

Aleric's right, this is even cleaner :-)

indra/llcommon/llavatarname.cpp (Diff revision 2)

Nitpicking now, but it should be "i.e.", not "ie". Also, the defaulted display name is NOT the same as the user name. (Mine would be "Boroondas Gupte" and "boroondas.gupte".) Actually, while one can derive the user name from the default display name, one cannot derive the default display name from the user name (because the casing is unknown). So maybe make the comment

	// If the display name feature is off
	// OR this particular display name is defaulted (i.e. based on user name),
	// then display only the easier to read instance of the person's name.

(I know "based on" is a bit fuzzy, so if someone can think of a more specific formulation that is still technically correct and not too compicated, go for it.)

ardy.lay March 4, 2011, 4:44 a.m. (March 4, 2011, 4:44 a.m.)

I prefer your version of the comment, Boroondas.  It does better describe what we are doing.  Thanks.

Diff
- added Diff r3

Description:

I edited my proposed change after considering the feedback provided by reviewers.  Thanks.
Diff updated.  Repository synced with viewer-development and diff applied.

Perfect :-)

You have a pending review.

Other reviews

Your comment

Review Board 1.6.11

This change has been marked as submitted.