OPEN-29: Error out if lldir_<platform>.h is included when building for a different platform.
Review Request #148 - Created Feb. 11, 2011 and submitted
| Boroondas Gupte | Reviewers | ||
| viewer | |||
| OPEN-29 | |||
| None | viewer-development | ||
Rather than relying on (probably anyway accidental) on syntax incompatibilities, added explicit #error to the indra/llvfs/lldir_*.h headers. In separate commits, but also in the diff for review here, removed one such syntax incompatibility (https://bitbucket.org/boroondas/open-29/changeset/19ab94811717 ) and did some cleanup (superfluous "public:"s, trailing whitespace).
Built on Linux before pulling https://bitbucket.org/lindenlab/viewer-development/changeset/7a1440277911 * Errors out as wanted. Build on Linux after pulling 7a1440277911 * Builds like normal. Note: These tests were done with other build fixes present * for VWR-24520 https://codereview.secondlife.com/r/97/ * for VWR-24487 https://codereview.secondlife.com/r/100/ not on a pristine source tree.
Expand AllReview request changed
Updated (Feb. 11, 2011, 6:07 a.m.)
-
Rather than relying on (probably anyway accidental) on syntax incompatibilities, added explicit #error to the indra/llvfs/lldir_*.h headers. In separate commits, but also in the diff for review here, removed one such syntax incompatibility (https://bitbucket.org/boroondas/open-29/changeset/19ab94811717) and did some cleanup (superfluous "public:"s, trailing whitespace).
Rather than relying on (probably anyway accidental) on syntax incompatibilities, added explicit #error to the indra/llvfs/lldir_*.h headers. In separate commits, but also in the diff for review here, removed one such syntax incompatibility (https://bitbucket.org/boroondas/open-29/changeset/19ab94811717 ) and did some cleanup (superfluous "public:"s, trailing whitespace).
(just edited description, so that the link there works)
Other reviews