All submissions to this site are governed by the Second Life Viewer Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.

Review Board 1.6.11

Welcome to the Second Life Viewer Code Review tool.
See the documentation on our wiki for how to use this site.

STORM-974 UI button alignment issues in Landmark panel, About Land window, and Hardware Settings window

Review Request #142 - Created Feb. 7, 2011 and submitted

Jonathan Yap Reviewers
2.6 viewer
STORM-974
None viewer-development
Please see the jira for the referenced pictures.

In picture #1, in the preferences > graphics > hardware settings, the line of "gamma" setting is a little too up and it collides with the "antialiasing" line.

In picture #2 in the "places" tab under "my landmarks" tab the "profile" button gets cut off at the end from the rest of the sidebar's UI.
There are a number of other buttons with alignment issues with no screenshot.

In picture #3 in the Access tab in the About Land window, the remove buttons are off to the right a few millimetres.

Changes made were to align the Hardware Settings and About Land buttons and to completely go over the buttons in the Landmarks panel.  The small down-arrow at the bottom right corner was using an imbedded UTF-8 so I fixed that and also made it point up while the menu is open (there is a separate jira for reversing the direction it points in these two states).

This patch really needs a test viewer built to make sure all works and that nothing was missed in the Landmarks panel.  There are 3 other related jiras that I hope are taken in; a test viewer could be made incorporating all 4 jiras at that point.

 
Review request changed
Updated (Feb. 8, 2011, 5:22 a.m.)
Took out the changes to flip the down-arrow in the bottom right of the Landmark panel to an up-arrow when it is pushed as that change is not within the scope of this jira.
Ship it!
Posted (Feb. 15, 2011, 9:54 a.m.)