All submissions to this site are governed by the Second Life Viewer Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.
Welcome to the Second Life Viewer Code Review tool.
See the documentation on our wiki for how to use this site.
Review Request #131 - Created Jan. 30, 2011 and updated
| Nicky Perian | Reviewers | ||
| viewer | |||
| OPEN-46 | |||
| None | viewer-development | ||
Copy3rdPartyLibs.cmake need to respond correctly under Visual Studio 10 and Visual Studio 10 Express Edition.
Tested good under windows 7 64 bit and Visual Studio 10 Express Edition.
| indra/cmake/Copy3rdPartyLibs.cmake (Diff revision 1) |
|---|
Examine the attached file in https://jira.secondlife.com/browse/STORM-932 and my comment at the bottom on how to avoid duplicating code in this file.
Modified to include Jonathan Yap's review recommendation from https://jira.secondlife.com/browse/STORM-932. Added code from merov's wip at https://jira.secondlife.com/browse/STORM-860 variable declarations for MSVC_DIR and MSVC_SUFFIX and added values for Visual Studio 10. Tested OK under windows 7 64 bit and Visual Studio 10 Express Edition.
Good factorization job. Thanks for doing this. I have not tried the patch though and recommend MM to do a full TC cycle before merging in viewer-development.
Expand All
Other reviews