Use consistent path for all *.py scripts


Submitter:	Merov Linden	Reviewers
Branch:	https://merov_linden@bitbucket.org/merov_linden/viewer-development-storm-937	Groups:	viewer
Bugs:	STORM-937	People:
Change Number:	None	Repository:	viewer-development

Description:

Simple consistency change, using "#!/usr/bin/python" in all python script.

Testing Done:

Pulled into a test repo and build successfully on all platforms on TC so I guess no bad surprise here.

Expand All

Looks like a good consistency improvement.

Covers all occurrences of the variant with env, so should be fine.

As currently both variants are present, choosing only one of them (no matter which) should not hinder anyone who can already use the scripts today (except if they only used scripts with one of the variants, up to now.) If we later discover that using the other variant would bring any advantage (like, allowing to call the script directly rather than prepending the interpreter command) we can always make that change later.

Why didn't you choose "!/usr/bin/env python"? It seems more flexible.

Balp Allen Jan. 31, 2011, 12:26 p.m. (Jan. 31, 2011, 12:26 p.m.)

!/usr/bin/env python, is the standard python way, and i think is what should always be used on python scripts.

I would much prefer that we put the /usr/bin/env python form, since env can find whichever python is currently set up, including someone that has it in /usr/local/bin, or wherever they've chosen. Env is more likely to be found in /usr/bin than python is. So I'd like to see this change made the opposite way.

Vadim ProductEngine Jan. 31, 2011, 11:51 a.m. (Jan. 31, 2011, 11:51 a.m.)
```
+1
```

Merov Linden Jan. 31, 2011, 6:12 p.m. (Jan. 31, 2011, 6:12 p.m.)

I'm all for it since everybody seems to agree on this syntax (which is less error prone for 3rd party devs, I agree). Still, as mentioned by Brad in the JIRA, we should revise and dust off the wiki: http://wiki.secondlife.com/wiki/Coding_standard#Python_File_Names. In particular, I don't think we want .pyo or .pyc files around anymore (all the .py files in lindenlab/viewer-development are open source).

Diff
- added Diff r2

Description:

Took comments into account:
- Changed to use the #!/usr/bin/env python shebang line
- Add license info to python files that were missing one
- Reformatted some license header for consistency
- Updated wiki http://wiki.secondlife.com/wiki/Coding_standard#Python to make those aspects (shebang and licensing) clear

Those changes look good.

For future reference, there's no reason to add date ranges in Copyright headers - the only year needed is the year of first publication.  Adding additional years is not needed and serves no purpose.

Diff
- added Diff r3

Description:

The previous change revealed issues on Windows, namely, the use of the commands module on Windows in llversion.py. I changed that to use subprocess instead and cleaned up old svn functions rather than "fixing" them.

The code has been integrated. Merov, please close the review request.

You have a pending review.

Other reviews

Your comment

Review Board 1.6.11

This change has been marked as submitted.