All submissions to this site are governed by the Second Life Viewer Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.

Review Board 1.6.11

Welcome to the Second Life Viewer Code Review tool.
See the documentation on our wiki for how to use this site.

STORM-643 mini-map control displayed at top of Nearby people tab

Review Request #124 - Created Jan. 25, 2011 and submitted

Twisted Laws Reviewers
viewer
STORM-643
None viewer-development
This patch fulfils STORM-643 by putting a copy of the mini-map control into the top of the Nearby tab of the People panel.  Both this and the mini-map can be open at the same time.  While working on this a bug was noticed in the hovertip of the minimap and a solution proposed for that as well although that adds a translation task.  Some of the code from llfloatermap.cpp is actually duplicated here without removing the code from there.  This doesn't have an effect since the control is pushed to the back in llfloatermap.cpp.  The code duplication could be removed from llfloatermap.cpp (the original source) but that may affect something I'm not aware of.
This patch seems to work fine and tested under by compiling and running under Windows 7.0 (64) and Ubuntu Linux.

Tested by having all combinations of mini-map (existing) open and closed, having the people panel open on all of the different tabs with the only effect on the Nearby tab, and having the panel docked in sidebar and not docked.  The highlighting of avatars that are selected in the avatar list only affect the copy of the mini-map displayed there.
Review request changed
Updated (Jan. 26, 2011, 3:34 p.m.)
Patch after the original patch, this corrects the Stop Tracking menu option not working properly.
Posted (Jan. 28, 2011, 5:34 a.m.)
Why was this request closed as submitted if it hasn't been approved?
Ship it!
Posted (Jan. 28, 2011, 8:13 a.m.)
Fine with me. No evident issues spotted.